12: Bad Aim


#1

I'm currently stuck on this exercise. It keeps giving me this error message: Traceback (most recent call last):
File "python", line 32, in
IndexError: list index out of range
It's referring to the first "board[guess_row] [guess_col] = "X" line. I don't understand how it's out of range or what's wrong with it, because I read through the forum, and plenty of other users have the exact same code. I'm almost positive my indentation is correct. Please help!!

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row] [guess_col] = "X"
    print_board(board)
    if guess_row not in range(5) or \
guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)

12. Bad Aim
#2

This check should come right after the check for a win so the range is tested before anything else.


12. Bad Aim
#3

Ahhh, I see now. Thank you!


#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.