12. Bad Aim - Error: File "python", like 33, in <module> IndexError: list index out of range


#1



https://www.codecademy.com/en/courses/python-beginner-en-4XuFm/1/3?curriculum_id=4f89dab3d788890003000096


If the user enters a number higher than 5, the program should output "Opps, that's not even in the ocean." but instead I get the error "File "python", line 33, in IndexError: list index out of range.

It doesn't throw that error when I enter a number that is less than 5 however. Could you guys please help me figure this out? :slight_smile:

Here is a screenshot http://i.imgur.com/XYTKieI.png


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print print_board(board)
    
    if guess_row not in range(5) or \
        guess_col not in range(5):
            print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print print_board(board)


#3

if guess_row not in range(5) or \
        guess_col not in range(5):
            print "Oops, that's not even in the ocean."
else:
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sank my battleship!"
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print print_board(board)

#4

Hello Konaesan! Thank you for stopping by!

 I tried the code you posted and it makes sense but still got the same error. Any idea why this might be?

Here is a screenshot: http://i.imgur.com/LwQQa6I.png

This is the modified code:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print print_board(board)
    
if guess_row not in range(5) or guess_col not in range(5):
    print "Oops, that's not even in the ocean."
else:
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sank my battleship!"
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print print_board(board)

#5

Hi @mewtwostrikesagain...
You must remove:

It must be something like:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row not in range(5) or \
        guess_col not in range(5):
            print "Oops, that's not even in the ocean."
else:
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sank my battleship!"
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print print_board(board)

#6

Wow! I removed the part you pointed out and bam! it worked perfectly !

Thank you very much for helping :slight_smile:


#7

You're welcome dude.
Good continuation! :+1:


#8

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.