12/19 Bad Aim. Issue with values greater than 5


#1



https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/3?curriculum_id=4f89dab3d788890003000096#

My code seems to work when I enter in values that either hit the ship or miss the ship, but I get an error when I enter in values beyond the range(5).

The error I am receiving is:

Traceback (most recent call last):
File "python", line 32, in
IndexError: list index out of range


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    board[guess_row][guess_col] = 'X'
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"


#2

you must enter number lower than 5, this is normali, because in here:

for x in range(0, 5):
    board.append(["O"] * 5)

now....
you create a list in length 5 , see this:

>>> ["O"] * 5
['O', 'O', 'O', 'O', 'O']

and put each of them in a new row, and your row length is 5 because

for x in range(0, 5)

run for 5 time.
now you have

['O', 'O', 'O', 'O', 'O']
['O', 'O', 'O', 'O', 'O']
['O', 'O', 'O', 'O', 'O']
['O', 'O', 'O', 'O', 'O']
['O', 'O', 'O', 'O', 'O']

if you enter 4 and 4 is ok; but if your input number go over than 4,4 python raise index out of range error.

i don't remember, may be in next courses you must write a part code for solve this problem(index out of range error)


#3

Yeah it seems I figured it out further into the exercises. Thanks for the help.