# 11. Danger, Will Robinson

#1

Hello, I am having issues because when I run the code the column and row that I guessed only places 1 "X" in the whole row as shown and doesn't show the rest of the "O":

Any advice or guidance would be appreciated.

``````from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
else:
print "You missed my battleship!"
board[guess_row] = "X"
board[guess_col] = "X"
print_board(board)``````

#2

We need to combine the indices...

``board[guess_row][guess_col]``

Recall that `board` is a list of lists. The row points to the list, the col points to the item in that list.

#3

Shouldn't that be board[guess_row - 1] = "X" and board[guess_col - 1] = "X" since values start at 0?

#4

``````board = [
['O', 'O', 'O', 'O', 'O'],    # guess_row
['O', 'O', 'O', 'O', 'O'],
['O', 'O', 'O', 'O', 'O'],
['O', 'O', 'O', 'O', 'O'],
['O', 'O', 'O', 'O', 'O']
]``````

Now consider,

``board[guess_row - 1] = "X"``

If `guess_row` is `0` this will result in the last position being selected, but assuming it is not `0` (say, `4`) then the result will be,

``````board = [
['O', 'O', 'O', 'O', 'O'],
['O', 'O', 'O', 'O', 'O'],
['O', 'O', 'O', 'O', 'O'],
"X",                        # guess_row == 4
['O', 'O', 'O', 'O', 'O']
]``````

#5

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.