11/19 Danger, Will Robinson (bug?)


#1

This is weird and I'm not sure if it's a bug or not. I entered the code below and it works perfectly with a guess of 2, 4 printing:

You missed my battleship!
O O O O O
O O O X O
O O O O O
O O O O O
O O O O O

But the lesson wants me to remove the "- 1" from the line that shows board[guess_row - 1][guess_col - 1] = "X"
which then prints, but says the lesson is correct.
O O O O O
O O O O O
O O O O X
O O O O O
O O O O O

Am I stupid or does mine not print correctly for the guess?

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row - 1][guess_col - 1] = "X"
    print_board(board)

#2

It turns out this is how I had to write the code to get it to function properly: fixes start at "guess_row = int(raw_input("Guess Row:"))"

overly complicated fix 1

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

for turn in range(4):
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    
    if (guess_row -1) == ship_row and (guess_col - 1) == ship_col:
        print "Congratulations! You sunk my battleship!"
        break
    else:
        if (guess_row < 0 or guess_row > 5) or (guess_col < 0 or guess_col > 5):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row - 1][guess_col - 1] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row - 1][guess_col - 1] = "X"
            if turn == 3:
                print "Game Over"
        print (turn + 1)
        print_board(board)

less complicated fix 2

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

for turn in range(4):
    guess_row = int(raw_input("Guess Row:"))-1
    guess_col = int(raw_input("Guess Col:"))-1
    
    if (guess_row) == ship_row and (guess_col) == ship_col:
        print "Congratulations! You sunk my battleship!"
        break
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
            if turn == 3:
                print "Game Over"
        print (turn + 1)
        print_board(board)

#3

Hey I made same mistake.
check this out.

from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))-1
guess_col = int(raw_input("Guess Col:"))-1

print ship_row
print ship_col

Write your code below!

if guess_row== ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
else :
print "You missed my battleship!"
board[guess_row][guess_col]= "X"
print_board(board)