11/19 Bad Aim


#1

Plz look at this code and tell me what's wrong
from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

Write your code below!

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
else:
if guess_row not in range(5) and guess_col not in range(5):
print "Oops, that's not even in the coean."
else:
print "You missed my battleship!"
board[guess_row][guess_col] = "X"
print_board(board)

it prints:
O O O O O
O O O O O
O O O O O
O O O O O
O O O O O
Guess Row: 6
Guess Col: 6
1
4
Oops, that's not even in the coean.
None

But it says:
Oops, try again. Make sure you print "Oops, that's not even in the ocean." if the user guesses a row or column that is off the board.

plz help me :frowning:


#2

Never mind, but if you r have the same problem or are having some trouble, here is my code that worked, just make sure to indent:

from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

Write your code below!

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
elif guess_row not in range(1,5) and guess_col is not range(1,5):
print "Oops, that's not even in the ocean."
else:
print "You missed my battleship!"
board[guess_row][guess_col] = "X"
print_board(board)

:smile:


#3

use elif instead if for the second condition